Skip to content

chore: Add copyright and license to generate_models.sh#45

Merged
damaz91 merged 3 commits into
mainfrom
chore/copyright
Jun 24, 2026
Merged

chore: Add copyright and license to generate_models.sh#45
damaz91 merged 3 commits into
mainfrom
chore/copyright

Conversation

@damaz91

@damaz91 damaz91 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description

Add copyright notice and licensing information to the generate_model.sh script .

Category (Required)

Please select one or more categories that apply to this change.

  • Core Protocol: Changes to the base communication layer, global context, or breaking refactors. (Requires Technical Council approval)
  • Governance/Contributing: Updates to GOVERNANCE.md, CONTRIBUTING.md, or CODEOWNERS. (Requires Governance Council approval)
  • Capability: New schemas (Discovery, Cart, etc.) or extensions. (Requires Maintainer approval)
  • Documentation: Updates to README, or documentations regarding schema or capabilities. (Requires Maintainer approval)
  • Infrastructure: CI/CD, Linters, or build scripts. (Requires DevOps Maintainer approval)
  • Maintenance: Version bumps, lockfile updates, or minor bug fixes. (Requires DevOps Maintainer approval)
  • SDK: Language-specific SDK updates and releases. (Requires DevOps Maintainer approval)
  • Samples / Conformance: Maintaining samples and the conformance suite. (Requires Maintainer approval)
  • UCP Schema: Changes to the ucp-schema tool (resolver, linter, validator). (Requires Maintainer approval)
  • Community Health (.github): Updates to templates, workflows, or org-level configs. (Requires DevOps Maintainer approval)

Checklist

  • I have followed the Contributing Guide (including Conventional Commits title requirements and ! for breaking changes).
  • I have updated the documentation (if applicable).
  • My changes pass all local linting and formatting checks.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • (For Core/Capability) I have included/updated the relevant JSON schemas.
  • I have regenerated Python Pydantic models by running generate_models.sh under python_sdk.

Add copyright notice and licensing information to the script.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a copyright header to the generate_models.sh script. However, the header was placed before the shebang (#!/bin/bash), which prevents the operating system from correctly identifying the interpreter. The feedback correctly points out this issue and suggests moving the shebang to the very first line of the script to ensure proper execution.

Comment thread generate_models.sh
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@damaz91 damaz91 marked this pull request as ready for review June 24, 2026 08:28
@damaz91 damaz91 requested review from a team as code owners June 24, 2026 08:28
@damaz91 damaz91 requested review from MitkoDeyanovMitev, archrao, cusell-google and pemamian and removed request for a team June 24, 2026 08:28
@damaz91 damaz91 merged commit b3c1435 into main Jun 24, 2026
11 checks passed
@damaz91 damaz91 deleted the chore/copyright branch June 24, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants